lbsadmin/Beego
1
0
Fork 0
mirror of https://github.com/astaxie/beego.git synced 2024-11-22 09:30:56 +00:00
Code Issues Releases Activity

remove SA1024 staticchek

Browse Source
This commit is contained in:
JessonChan 2019-01-22 20:52:06 +08:00
parent 2a579eb27c
commit 0145fe3486
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.travis.yml
View File

@ -55,7 +55,7 @@ after_script:
- rm -rf ./res/var/* - rm -rf ./res/var/*
script: script:
- go test -v ./... - go test -v ./...
- staticcheck -show-ignored -checks "-ST1017,-U1000,-ST1005,-S1034,-S1012,-SA4006,-SA6005,-SA1019" - staticcheck -show-ignored -checks "-ST1017,-U1000,-ST1005,-S1034,-S1012,-SA4006,-SA6005,-SA1019,-SA1024"
- unconvert $(go list ./... | grep -v /vendor/) - unconvert $(go list ./... | grep -v /vendor/)
- ineffassign . - ineffassign .
- find . ! \( -path './vendor' -prune \) -type f -name '*.go' -print0 | xargs -0 gofmt -l -s - find . ! \( -path './vendor' -prune \) -type f -name '*.go' -print0 | xargs -0 gofmt -l -s

14
parser.go
View File

@ -259,9 +259,9 @@ func parseComment(lines []*ast.Comment) (pcs []*parsedComment, err error) {
imports := []parsedImport{} imports := []parsedImport{}
for _, c := range lines { for _, c := range lines {
t := strings.TrimSpace(strings.TrimPrefix(c.Text, "//")) t := strings.TrimSpace(strings.TrimLeft(c.Text, "//"))
if strings.HasPrefix(t, "@Param") { if strings.HasPrefix(t, "@Param") {
pv := getparams(strings.TrimSpace(strings.TrimPrefix(t, "@Param"))) pv := getparams(strings.TrimSpace(strings.TrimLeft(t, "@Param")))
if len(pv) < 4 { if len(pv) < 4 {
logs.Error("Invalid @Param format. Needs at least 4 parameters") logs.Error("Invalid @Param format. Needs at least 4 parameters")
} }
@ -286,7 +286,7 @@ func parseComment(lines []*ast.Comment) (pcs []*parsedComment, err error) {
} }
for _, c := range lines { for _, c := range lines {
t := strings.TrimSpace(strings.TrimPrefix(c.Text, "//")) t := strings.TrimSpace(strings.TrimLeft(c.Text, "//"))
if strings.HasPrefix(t, "@Import") { if strings.HasPrefix(t, "@Import") {
iv := getparams(strings.TrimSpace(strings.TrimLeft(t, "@Import"))) iv := getparams(strings.TrimSpace(strings.TrimLeft(t, "@Import")))
if len(iv) == 0 || len(iv) > 2 { if len(iv) == 0 || len(iv) > 2 {
@ -307,9 +307,9 @@ func parseComment(lines []*ast.Comment) (pcs []*parsedComment, err error) {
filterLoop: filterLoop:
for _, c := range lines { for _, c := range lines {
t := strings.TrimSpace(strings.TrimLeft(c.Text, "/")) t := strings.TrimSpace(strings.TrimLeft(c.Text, "//"))
if strings.HasPrefix(t, "@Filter") { if strings.HasPrefix(t, "@Filter") {
fv := getparams(strings.TrimSpace(strings.TrimPrefix(t, "@Filter"))) fv := getparams(strings.TrimSpace(strings.TrimLeft(t, "@Filter")))
if len(fv) < 3 { if len(fv) < 3 {
logs.Error("Invalid @Filter format. Needs at least 3 parameters") logs.Error("Invalid @Filter format. Needs at least 3 parameters")
continue filterLoop continue filterLoop
@ -349,9 +349,9 @@ filterLoop:
pc.filters = filters pc.filters = filters
pc.imports = imports pc.imports = imports
t := strings.TrimSpace(strings.TrimLeft(c.Text, "/")) t := strings.TrimSpace(strings.TrimLeft(c.Text, "//"))
if strings.HasPrefix(t, "@router") { if strings.HasPrefix(t, "@router") {
t := strings.TrimSpace(strings.TrimLeft(c.Text, "/")) t := strings.TrimSpace(strings.TrimLeft(c.Text, "//"))
matches := routeRegex.FindStringSubmatch(t) matches := routeRegex.FindStringSubmatch(t)
if len(matches) == 3 { if len(matches) == 3 {
pc.routerPath = matches[1] pc.routerPath = matches[1]