From 221306fff4a2614a6717e53f471f03fc275ac30a Mon Sep 17 00:00:00 2001 From: JessonChan Date: Tue, 29 Mar 2016 10:05:56 +0800 Subject: [PATCH] file rotate bug --- logs/file.go | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/logs/file.go b/logs/file.go index 159d4970..5901143b 100644 --- a/logs/file.go +++ b/logs/file.go @@ -60,14 +60,11 @@ type fileLogWriter struct { // newFileWriter create a FileLogWriter returning as LoggerInterface. func newFileWriter() Logger { w := &fileLogWriter{ - Filename: "", - MaxLines: 1000000, - MaxSize: 1 << 28, //256 MB - Daily: true, - MaxDays: 7, - Rotate: true, - Level: LevelTrace, - Perm: 0660, + Daily: true, + MaxDays: 7, + Rotate: true, + Level: LevelTrace, + Perm: 0660, } return w } @@ -259,8 +256,8 @@ func (w *fileLogWriter) deleteOldLog() { } }() - if !info.IsDir() && info.ModTime().Unix() < (time.Now().Unix()-60*60*24*w.MaxDays) { - if strings.HasPrefix(filepath.Base(path), w.fileNameOnly) && + if !info.IsDir() && info.ModTime().Add(24*time.Hour*time.Duration(w.MaxDays)).Before(time.Now()) { + if strings.HasPrefix(filepath.Base(path), filepath.Base(w.fileNameOnly)) && strings.HasSuffix(filepath.Base(path), w.suffix) { os.Remove(path) }