fix issue 4311

client/cache/memcache/memcache.go

@@ -33,6 +33,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"strings"
 	"time"
 
@@ -68,19 +69,31 @@ func (rc *Cache) Get(ctx context.Context, key string) (interface{}, error) {
 
 // GetMulti gets a value from a key in memcache.
 func (rc *Cache) GetMulti(ctx context.Context, keys []string) ([]interface{}, error) {
-	var rv []interface{}
+	rv := make([]interface{}, len(keys))
 	if rc.conn == nil {
 		if err := rc.connectInit(); err != nil {
 			return rv, err
 		}
 	}
+
 	mv, err := rc.conn.GetMulti(keys)
-	if err == nil {
-		for _, v := range mv {
-			rv = append(rv, v.Value)
-		}
+	if err != nil {
+		return rv, err
 	}
-	return rv, err
+
+	keysErr := make([]string, 0)
+	for i, ki := range keys {
+		if _, ok := mv[ki]; !ok {
+			keysErr = append(keysErr, fmt.Sprintf("key [%s] error: %s", ki, "the key isn't exist"))
+			continue
+		}
+		rv[i] = mv[ki].Value
+	}
+
+	if len(keysErr) == 0 {
+		return rv, nil
+	}
+	return rv, fmt.Errorf(strings.Join(keysErr, "; "))
 }
 
 // Put puts a value into memcache.

client/cache/memcache/memcache_test.go

@@ -28,7 +28,6 @@ import (
 )
 
 func TestMemcacheCache(t *testing.T) {
-
 	addr := os.Getenv("MEMCACHE_ADDR")
 	if addr == "" {
 		addr = "127.0.0.1:11211"
@@ -114,6 +113,20 @@ func TestMemcacheCache(t *testing.T) {
 		t.Error("GetMulti ERROR")
 	}
 
+	vv, err = bm.GetMulti(context.Background(), []string{"astaxie0", "astaxie1"})
+	if len(vv) != 2 {
+		t.Error("GetMulti ERROR")
+	}
+	if vv[0] != nil {
+		t.Error("GetMulti ERROR")
+	}
+	if string(vv[1].([]byte)) != "author1" {
+		t.Error("GetMulti ERROR")
+	}
+	if err != nil && err.Error() == "key [astaxie0] error: key isn't exist" {
+		t.Error("GetMulti ERROR")
+	}
+
 	// test clear all
 	if err = bm.ClearAll(context.Background()); err != nil {
 		t.Error("clear all err")