Merge pull request #1805 from JessonChan/abort_panic_bug

Abort panic bug

context/context.go

@@ -77,6 +77,7 @@ func (ctx *Context) Redirect(status int, localurl string) {
 // Abort stops this request.
 // if beego.ErrorMaps exists, panic body.
 func (ctx *Context) Abort(status int, body string) {
+	ctx.Output.SetStatus(status)
 	panic(body)
 }
 

controller.go

@@ -261,12 +261,13 @@ func (c *Controller) Abort(code string) {
 
 // CustomAbort stops controller handler and show the error data, it's similar Aborts, but support status code and body.
 func (c *Controller) CustomAbort(status int, body string) {
-	c.Ctx.Output.Status = status
 	// first panic from ErrorMaps, is is user defined error functions.
 	if _, ok := ErrorMaps[body]; ok {
+		c.Ctx.Output.Status = status
 		panic(body)
 	}
 	// last panic user string
+	c.Ctx.ResponseWriter.WriteHeader(status)
 	c.Ctx.ResponseWriter.Write([]byte(body))
 	panic(ErrAbort)
 }

error.go

@@ -210,159 +210,139 @@ var ErrorMaps = make(map[string]*errorInfo, 10)
 
 // show 401 unauthorized error.
 func unauthorized(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(401),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested can't be authorized." +
+	responseError(rw, r,
+		401,
+		"<br>The page you have requested can't be authorized."+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br>The credentials you supplied are incorrect"+
 			"<br>There are errors in the website address"+
-		"</ul>")
-	t.Execute(rw, data)
+			"</ul>",
+	)
 }
 
 // show 402 Payment Required
 func paymentRequired(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(402),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested Payment Required." +
+	responseError(rw, r,
+		402,
+		"<br>The page you have requested Payment Required."+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br>The credentials you supplied are incorrect"+
 			"<br>There are errors in the website address"+
-		"</ul>")
-	t.Execute(rw, data)
+			"</ul>",
+	)
 }
 
 // show 403 forbidden error.
 func forbidden(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(403),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested is forbidden." +
+	responseError(rw, r,
+		403,
+		"<br>The page you have requested is forbidden."+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br>Your address may be blocked"+
 			"<br>The site may be disabled"+
 			"<br>You need to log in"+
-		"</ul>")
-	t.Execute(rw, data)
+			"</ul>",
+	)
 }
 
 // show 404 not found error.
 func notFound(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(404),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested has flown the coop." +
+	responseError(rw, r,
+		404,
+		"<br>The page you have requested has flown the coop."+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br>The page has moved"+
 			"<br>The page no longer exists"+
 			"<br>You were looking for your puppy and got lost"+
 			"<br>You like 404 pages"+
-		"</ul>")
-	t.Execute(rw, data)
+			"</ul>",
+	)
 }
 
 // show 405 Method Not Allowed
 func methodNotAllowed(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(405),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The method you have requested Not Allowed." +
+	responseError(rw, r,
+		405,
+		"<br>The method you have requested Not Allowed."+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br>The method specified in the Request-Line is not allowed for the resource identified by the Request-URI"+
 			"<br>The response MUST include an Allow header containing a list of valid methods for the requested resource."+
-		"</ul>")
-	t.Execute(rw, data)
+			"</ul>",
+	)
 }
 
 // show 500 internal server error.
 func internalServerError(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(500),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested is down right now." +
+	responseError(rw, r,
+		500,
+		"<br>The page you have requested is down right now."+
 			"<br><br><ul>"+
 			"<br>Please try again later and report the error to the website administrator"+
-		"<br></ul>")
-	t.Execute(rw, data)
+			"<br></ul>",
+	)
 }
 
 // show 501 Not Implemented.
 func notImplemented(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(504),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested is Not Implemented." +
+	responseError(rw, r,
+		501,
+		"<br>The page you have requested is Not Implemented."+
 			"<br><br><ul>"+
 			"<br>Please try again later and report the error to the website administrator"+
-		"<br></ul>")
-	t.Execute(rw, data)
+			"<br></ul>",
+	)
 }
 
 // show 502 Bad Gateway.
 func badGateway(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(502),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested is down right now." +
+	responseError(rw, r,
+		502,
+		"<br>The page you have requested is down right now."+
 			"<br><br><ul>"+
 			"<br>The server, while acting as a gateway or proxy, received an invalid response from the upstream server it accessed in attempting to fulfill the request."+
 			"<br>Please try again later and report the error to the website administrator"+
-		"<br></ul>")
-	t.Execute(rw, data)
+			"<br></ul>",
+	)
 }
 
 // show 503 service unavailable error.
 func serviceUnavailable(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(503),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested is unavailable." +
+	responseError(rw, r,
+		503,
+		"<br>The page you have requested is unavailable."+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br><br>The page is overloaded"+
 			"<br>Please try again later."+
-		"</ul>")
-	t.Execute(rw, data)
+			"</ul>",
+	)
 }
 
 // show 504 Gateway Timeout.
 func gatewayTimeout(rw http.ResponseWriter, r *http.Request) {
-	t, _ := template.New("beegoerrortemp").Parse(errtpl)
-	data := map[string]interface{}{
-		"Title":        http.StatusText(504),
-		"BeegoVersion": VERSION,
-	}
-	data["Content"] = template.HTML("<br>The page you have requested is unavailable." +
+	responseError(rw, r,
+		504,
+		"<br>The page you have requested is unavailable"+
 			"<br>Perhaps you are here because:"+
 			"<br><br><ul>"+
 			"<br><br>The server, while acting as a gateway or proxy, did not receive a timely response from the upstream server specified by the URI."+
 			"<br>Please try again later."+
-		"</ul>")
+			"</ul>",
+	)
+}
+
+func responseError(rw http.ResponseWriter, r *http.Request, errCode int, errContent string) {
+	t, _ := template.New("beegoerrortemp").Parse(errtpl)
+	data := map[string]interface{}{
+		"Title":        http.StatusText(errCode),
+		"BeegoVersion": VERSION,
+		"Content":      errContent,
+	}
 	t.Execute(rw, data)
 }
 
@@ -408,8 +388,11 @@ func exception(errCode string, ctx *context.Context) {
 		if err == nil {
 			return v
 		}
+		if ctx.Output.Status == 0 {
 			return 503
 		}
+		return ctx.Output.Status
+	}
 
 	for _, ec := range []string{errCode, "503", "500"} {
 		if h, ok := ErrorMaps[ec]; ok {

error_test.go

@@ -0,0 +1,88 @@
+// Copyright 2016 beego Author. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package beego
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"strconv"
+	"strings"
+	"testing"
+)
+
+type errorTestController struct {
+	Controller
+}
+
+const parseCodeError = "parse code error"
+
+func (ec *errorTestController) Get() {
+	errorCode, err := ec.GetInt("code")
+	if err != nil {
+		ec.Abort(parseCodeError)
+	}
+	if errorCode != 0 {
+		ec.CustomAbort(errorCode, ec.GetString("code"))
+	}
+	ec.Abort("404")
+}
+
+func TestErrorCode_01(t *testing.T) {
+	registerDefaultErrorHandler()
+	for k, _ := range ErrorMaps {
+		r, _ := http.NewRequest("GET", "/error?code="+k, nil)
+		w := httptest.NewRecorder()
+
+		handler := NewControllerRegister()
+		handler.Add("/error", &errorTestController{})
+		handler.ServeHTTP(w, r)
+		code, _ := strconv.Atoi(k)
+		if w.Code != code {
+			t.Fail()
+		}
+		if !strings.Contains(string(w.Body.Bytes()), http.StatusText(code)) {
+			t.Fail()
+		}
+	}
+}
+
+func TestErrorCode_02(t *testing.T) {
+	registerDefaultErrorHandler()
+	r, _ := http.NewRequest("GET", "/error?code=0", nil)
+	w := httptest.NewRecorder()
+
+	handler := NewControllerRegister()
+	handler.Add("/error", &errorTestController{})
+	handler.ServeHTTP(w, r)
+	if w.Code != 404 {
+		t.Fail()
+	}
+}
+
+func TestErrorCode_03(t *testing.T) {
+	registerDefaultErrorHandler()
+	r, _ := http.NewRequest("GET", "/error?code=panic", nil)
+	w := httptest.NewRecorder()
+
+	handler := NewControllerRegister()
+	handler.Add("/error", &errorTestController{})
+	handler.ServeHTTP(w, r)
+	if w.Code != 200 {
+		t.Fail()
+	}
+	if string(w.Body.Bytes()) != parseCodeError {
+		t.Fail()
+	}
+}

router.go

@@ -842,7 +842,7 @@ func (p *ControllerRegister) recoverPanic(context *beecontext.Context) {
 		}
 		if !BConfig.RecoverPanic {
 			panic(err)
-		} else {
+		}
 		if BConfig.EnableErrorsShow {
 			if _, ok := ErrorMaps[fmt.Sprint(err)]; ok {
 				exception(fmt.Sprint(err), context)
@@ -865,7 +865,6 @@ func (p *ControllerRegister) recoverPanic(context *beecontext.Context) {
 		}
 	}
 }
-}
 
 func toURL(params map[string]string) string {
 	if len(params) == 0 {