lbsadmin/Beego
1
0
Fork 0
mirror of https://github.com/astaxie/beego.git synced 2024-11-22 09:10:55 +00:00
Code Issues Releases Activity

Merge pull request #4066 from playHing/self-dev

Browse Source 
Fix concurrent issue of context/input Query method
This commit is contained in:
Ming Deng 2020-07-16 13:52:11 +08:00 committed by GitHub
commit 7a48fbb698
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
context/input.go
View File

@ -333,8 +333,14 @@ func (input *BeegoInput) Query(key string) string {
return val return val
} }
if input.Context.Request.Form == nil { if input.Context.Request.Form == nil {
input.Context.Request.ParseForm() input.dataLock.Lock()
if input.Context.Request.Form == nil {
input.Context.Request.ParseForm()
}
input.dataLock.Unlock()
} }
input.dataLock.RLock()
defer input.dataLock.RUnlock()
return input.Context.Request.Form.Get(key) return input.Context.Request.Form.Get(key)
} }

10
context/input_test.go
View File

@ -205,3 +205,13 @@ func TestParams(t *testing.T) {
} }
} }
func BenchmarkQuery(b *testing.B) {
beegoInput := NewInput()
beegoInput.Context = NewContext()
beegoInput.Context.Request, _ = http.NewRequest("POST", "http://www.example.com/?q=foo", nil)
b.RunParallel(func(pb *testing.PB) {
for pb.Next() {
beegoInput.Query("q")
}
})
}