From b838683731bbe683cff94b7c99dc01e6c4b059be Mon Sep 17 00:00:00 2001
From: Anker Jam <jianzhiyao020@qq.com>
Date: Mon, 5 Oct 2020 10:33:23 +0800
Subject: [PATCH] add api for testing

---
 pkg/adapter/toolbox/task.go      |  5 +++++
 pkg/adapter/toolbox/task_test.go |  4 ++++
 pkg/task/task.go                 | 36 ++++++++++++++++++++++++--------
 pkg/task/task_test.go            | 10 ++++++---
 4 files changed, 43 insertions(+), 12 deletions(-)

diff --git a/pkg/adapter/toolbox/task.go b/pkg/adapter/toolbox/task.go
index 2a6d9aa6..5b2fa14c 100644
--- a/pkg/adapter/toolbox/task.go
+++ b/pkg/adapter/toolbox/task.go
@@ -212,6 +212,11 @@ func DeleteTask(taskname string) {
 	task.DeleteTask(taskname)
 }
 
+// ClearTask clear all tasks
+func ClearTask() {
+	task.ClearTask()
+}
+
 // MapSorter sort map for tasker
 type MapSorter task.MapSorter
 
diff --git a/pkg/adapter/toolbox/task_test.go b/pkg/adapter/toolbox/task_test.go
index 596bc9c5..994c4976 100644
--- a/pkg/adapter/toolbox/task_test.go
+++ b/pkg/adapter/toolbox/task_test.go
@@ -22,6 +22,8 @@ import (
 )
 
 func TestParse(t *testing.T) {
+	defer ClearTask()
+
 	tk := NewTask("taska", "0/30 * * * * *", func() error { fmt.Println("hello world"); return nil })
 	err := tk.Run()
 	if err != nil {
@@ -34,6 +36,8 @@ func TestParse(t *testing.T) {
 }
 
 func TestSpec(t *testing.T) {
+	defer ClearTask()
+
 	wg := &sync.WaitGroup{}
 	wg.Add(2)
 	tk1 := NewTask("tk1", "0 12 * * * *", func() error { fmt.Println("tk1"); return nil })
diff --git a/pkg/task/task.go b/pkg/task/task.go
index 5faa2fd8..a781e47a 100644
--- a/pkg/task/task.go
+++ b/pkg/task/task.go
@@ -36,7 +36,7 @@ type taskManager struct {
 	taskLock      sync.RWMutex
 	stop          chan bool
 	changed       chan bool
-	isstart       bool
+	started       bool
 }
 
 func newTaskManager()*taskManager{
@@ -45,7 +45,7 @@ func newTaskManager()*taskManager{
 		taskLock:      sync.RWMutex{},
 		stop:          make(chan bool),
 		changed:       make(chan bool),
-		isstart:       false,
+		started:       false,
 	}
 }
 
@@ -431,16 +431,21 @@ func DeleteTask(taskName string) {
 	globalTaskManager.DeleteTask(taskName)
 }
 
+//  ClearTask clear all tasks
+func ClearTask() {
+	globalTaskManager.ClearTask()
+}
+
 
 // StartTask start all tasks
 func (m *taskManager) StartTask() {
 	m.taskLock.Lock()
 	defer m.taskLock.Unlock()
-	if m.isstart {
+	if m.started {
 		// If already started， no need to start another goroutine.
 		return
 	}
-	m.isstart = true
+	m.started = true
 
 	registerCommands()
 	go m.run()
@@ -488,8 +493,8 @@ func(m *taskManager) run() {
 			continue
 		case <-m.stop:
 			m.taskLock.Lock()
-			if m.isstart {
-				m.isstart = false
+			if m.started {
+				m.started = false
 			}
 			m.taskLock.Unlock()
 			return
@@ -510,7 +515,7 @@ func (m *taskManager)AddTask(taskname string, t Tasker) {
 	m.taskLock.Lock()
 	t.SetNext(nil, time.Now().Local())
 	m.adminTaskList[taskname] = t
-	if m.isstart {
+	if m.started {
 		isChanged = true
 	}
 	m.taskLock.Unlock()
@@ -529,16 +534,29 @@ func(m *taskManager) DeleteTask(taskname string) {
 
 	m.taskLock.Lock()
 	delete(m.adminTaskList, taskname)
-	if m.isstart {
+	if m.started {
 		isChanged = true
 	}
 	m.taskLock.Unlock()
 
 	if isChanged {
-		m.changed <- true
+		go func() {
+			m.changed <- true
+		}()
 	}
 }
 
+//  ClearTask clear all tasks
+func(m *taskManager) ClearTask() {
+	m.taskLock.Lock()
+	m.adminTaskList = make(map[string]Tasker)
+	m.taskLock.Unlock()
+
+	go func() {
+		m.changed <- true
+	}()
+}
+
 // MapSorter sort map for tasker
 type MapSorter struct {
 	Keys []string
diff --git a/pkg/task/task_test.go b/pkg/task/task_test.go
index 9a74ff24..2cb807ce 100644
--- a/pkg/task/task_test.go
+++ b/pkg/task/task_test.go
@@ -26,6 +26,8 @@ import (
 )
 
 func TestParse(t *testing.T) {
+	m := newTaskManager()
+	defer m.ClearTask()
 	tk := NewTask("taska", "0/30 * * * * *", func(ctx context.Context) error {
 		fmt.Println("hello world")
 		return nil
@@ -34,14 +36,15 @@ func TestParse(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	AddTask("taska", tk)
-	StartTask()
+	m.AddTask("taska", tk)
+	m.StartTask()
 	time.Sleep(3 * time.Second)
-	StopTask()
+	m.StopTask()
 }
 
 func TestModifyTaskListAfterRunning(t *testing.T) {
 	m := newTaskManager()
+	defer m.ClearTask()
 	tk := NewTask("taskb", "0/30 * * * * *", func(ctx context.Context) error {
 		fmt.Println("hello world")
 		return nil
@@ -65,6 +68,7 @@ func TestModifyTaskListAfterRunning(t *testing.T) {
 
 func TestSpec(t *testing.T) {
 	m := newTaskManager()
+	defer m.ClearTask()
 	wg := &sync.WaitGroup{}
 	wg.Add(2)
 	tk1 := NewTask("tk1", "0 12 * * * *", func(ctx context.Context) error { fmt.Println("tk1"); return nil })