lbsadmin/Beego
1
0
Fork 0
mirror of https://github.com/astaxie/beego.git synced 2024-11-05 09:20:55 +00:00
Code Issues Releases Activity

Merge pull request #4022 from jianzhiyao/develop

Browse Source 
stmt: fix bug of non concurrent security & add double check
This commit is contained in:
Ming Deng 2020-06-21 18:01:14 +08:00 committed by GitHub
commit e1386c448c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
orm/db_alias.go
View File

@ -120,17 +120,24 @@ func (d *DB) BeginTx(ctx context.Context, opts *sql.TxOptions) (*sql.Tx, error)
func (d *DB) getStmt(query string) (*sql.Stmt, error) { func (d *DB) getStmt(query string) (*sql.Stmt, error) {
d.RLock() d.RLock()
if stmt, ok := d.stmts[query]; ok { c, ok := d.stmts[query]
d.RUnlock() d.RUnlock()
return stmt, nil if ok {
return c, nil
}
d.Lock()
c, ok = d.stmts[query]
if ok {
d.Unlock()
return c, nil
} }
d.RUnlock()
stmt, err := d.Prepare(query) stmt, err := d.Prepare(query)
if err != nil { if err != nil {
d.Unlock()
return nil, err return nil, err
} }
d.Lock()
d.stmts[query] = stmt d.stmts[query] = stmt
d.Unlock() d.Unlock()
return stmt, nil return stmt, nil