Merge pull request #4173 from AllenX2018/fix-bug-queryRow

Fix issue 3866

pkg/orm/orm_raw.go

@@ -383,19 +383,33 @@ func (o *rawSet) QueryRow(containers ...interface{}) error {
 					}
 				}
 			} else {
-				for i := 0; i < ind.NumField(); i++ {
+				// define recursive function
-					f := ind.Field(i)
+				var recursiveSetField func(rv reflect.Value)
-					fe := ind.Type().Field(i)
+				recursiveSetField = func(rv reflect.Value) {
-					_, tags := parseStructTag(fe.Tag.Get(defaultStructTagName))
+					for i := 0; i < rv.NumField(); i++ {
-					var col string
+						f := rv.Field(i)
-					if col = tags["column"]; col == "" {
+						fe := rv.Type().Field(i)
-						col = nameStrategyMap[nameStrategy](fe.Name)
+
-					}
+						// check if the field is a Struct
-					if v, ok := columnsMp[col]; ok {
+						// recursive the Struct type
-						value := reflect.ValueOf(v).Elem().Interface()
+						if fe.Type.Kind() == reflect.Struct {
-						o.setFieldValue(f, value)
+							recursiveSetField(f)
+						}
+
+						_, tags := parseStructTag(fe.Tag.Get(defaultStructTagName))
+						var col string
+						if col = tags["column"]; col == "" {
+							col = nameStrategyMap[nameStrategy](fe.Name)
+						}
+						if v, ok := columnsMp[col]; ok {
+							value := reflect.ValueOf(v).Elem().Interface()
+							o.setFieldValue(f, value)
+						}
 					}
 				}
+
+				// init call the recursive function
+				recursiveSetField(ind)
 			}
 
 		} else {

pkg/orm/orm_test.go

@@ -1742,6 +1742,24 @@ func TestRawQueryRow(t *testing.T) {
 	throwFail(t, AssertIs(*status, 3))
 	throwFail(t, AssertIs(pid, nil))
 
+	type Embeded struct {
+		Email string
+	}
+	type queryRowNoModelTest struct {
+		Id         int
+		EmbedField Embeded
+	}
+
+	cols = []string{
+		"id", "email",
+	}
+	var row queryRowNoModelTest
+	query = fmt.Sprintf("SELECT %s%s%s FROM %suser%s WHERE id = ?", Q, strings.Join(cols, sep), Q, Q, Q)
+	err = dORM.Raw(query, 4).QueryRow(&row)
+	throwFail(t, err)
+	throwFail(t, AssertIs(row.Id, 4))
+	throwFail(t, AssertIs(row.EmbedField.Email, "nobody@gmail.com"))
+
 	// test for sql.Null* fields
 	nData := &DataNull{
 		NullString:  sql.NullString{String: "test sql.null", Valid: true},